Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly handle steamlocate app location tristate #902

Merged
merged 1 commit into from
Apr 21, 2024
Merged

fix: Properly handle steamlocate app location tristate #902

merged 1 commit into from
Apr 21, 2024

Conversation

Jan200101
Copy link
Member

find_app returns a complex a Result<Option<t>> which gives us the tristate of

  1. checked and its there
  2. checked and its not there
  3. something fucked up

we only caught 1 and 3

@GeckoEidechse GeckoEidechse changed the title chore: deal with the steamlocate app location tristate fix: Properly handle steamlocate app location tristate Apr 21, 2024
GeckoEidechse
GeckoEidechse approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should address https://northstar-kv.sentry.io/issues/5234059930/events/c1d10a43af454c0b97ab005045a3fb20/

@GeckoEidechse GeckoEidechse merged commit feba471 into R2NorthstarTools:main Apr 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jan200101 @GeckoEidechse