CON-1150 Updated the performance docs page with latest up-to-date figures #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
reviewed
Oct 28, 2022
|
@JohnJoser3 can you please take a look at this. |
JohnJoser3
approved these changes
Nov 9, 2022
|
|
||
| Higher scores are better. As you can see, the performance hit overall of | ||
| using an enclave is highly dependent on what exactly the code is doing | ||
| (primarily, memory access patterns). | ||
| (primarily, memory access patterns). The score delta shows the difference in percentage between the | ||
| same benchmark with SGX turned on and off. As expected there is a performance hit when SGX is used. |
There was a problem hiding this comment.
I think we can remove the sentence "As expected there is a performance hit when SGX is used." The numbers already tell that and we need not highlight it, IMO. Any thoughts, @shamsasari?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.