CON-1187: Fix QA tests by changing the name of "enclave-bundle" jars #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bon000
changed the title
shamsasari
suggested changes
Nov 9, 2022
...-enclave-gradle/src/main/kotlin/com/r3/conclave/plugin/enclave/gradle/GradleEnclavePlugin.kt
Outdated
Show resolved
Hide resolved
shamsasari
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA tests are currently failing because this is where we use a different technique to deploy our host applications.
In QA we generate call
distZip,distTartasks in order to bundle the host, upload it to the CRAFT VMs and unzip it.We have a bug when the host had multiple enclaves: we use the same name for different "enclave bundle" jars. Even though these jars are actually present in differently named directories, when we call
distZipwe actually take them out of the "directory structure" context and therefore they are conflicting.This causes issues in QA: Gradle complains about a missing strategy to handle this.
Changing the name as we do in this PR should solve this problem