[accounting] Added command to deal with unterminated radacct entries o…

…penwisp#47

Implements openwisp#3 of openwisp#47

django_freeradius/management/commands/cleanup_stale_radacct.py

@@ -0,0 +1,25 @@
+from datetime import timedelta
+
+from django.core.management import BaseCommand
+from django.utils.timezone import now
+
+from django_freeradius.models import RadiusAccounting
+
+
+class Command(BaseCommand):
+    help = "Closes active accounting sessions older than <days>"
+
+    def add_arguments(self, parser):
+        parser.add_argument('number_of_days', type=int)
+
+    def handle(self, *args, **options):
+        if options['number_of_days']:
+            days = now() - timedelta(days=options['number_of_days'])
+            sessions = RadiusAccounting.objects.filter(start_time__lt=days, stop_time=None)
+            for session in sessions:
+                # calculate seconds in between two dates
+                session.session_time = (now() - session.start_time).total_seconds()
+                session.stop_time = now()
+                session.update_time = session.stop_time
+                session.save()
+            self.stdout.write('Closed active sessions older than {} days'.format(options['number_of_days']))

django_freeradius/tests/test_admin.py

@@ -213,3 +213,15 @@ def test_nas_admin_save_model(self):
         self.assertNotContains(response, 'error')
         nas.refresh_from_db()
         self.assertEqual(nas.type, 'my-custom-type')
+
+    def test_cleanup_stale_radacct_command(self):
+        RadiusAccounting.objects.create(
+            unique_id='117', username='bob', nas_ip_address='127.0.0.1', start_time='2017-06-10 10:50:00',
+            authentication='RADIUS', connection_info_start='f', connection_info_stop='hgh',
+            input_octets='1', output_octets='4', update_time='2017-03-10 11:50:00'
+        )
+        call_command('cleanup_stale_radacct', 30)
+        session = RadiusAccounting.objects.get(unique_id='117')
+        self.assertNotEqual(session.stop_time, None)
+        self.assertNotEqual(session.session_time, None)
+        self.assertEqual(session.update_time, session.stop_time)

docs/source/general/management_commands.rst

@@ -42,3 +42,18 @@ For example:
 .. code-block:: shell
 
     ./manage.py delete_old_postauth 365
+
+``cleanup_stale_radacct``
+-------------------------
+
+This command closes active RADIUS sessions that are open since <days>.
+
+.. code-block:: shell
+
+    ./manage.py cleanup_stale_radacct <days>
+
+For example:
+
+.. code-block:: shell
+
+    ./manage.py cleanup_stale_radacct 30