New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs about paths to keystore.p12 and make the expiration consistent with application-*.yml #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, fine to merge otherwise.
@@ -7,7 +7,8 @@ generated/ | |||
/src/test/javascript/coverage/ | |||
/src/test/javascript/PhantomJS*/ | |||
keystore.jks | |||
keystore.p12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just keystore.p12
is intentional. Any file that should then not be ignored is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... Reverted my unintentional change.
Update the paths to keystore.p12 and make the expiration consistent with application-*.yml.