Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/build issues windows os2 #712

Merged
merged 4 commits into from Sep 12, 2023
Merged

Fix/build issues windows os2 #712

merged 4 commits into from Sep 12, 2023

Conversation

Bdegraaf1234
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 commented Sep 8, 2023 •
edited

Description: Changes to build.gradle to enable building from source on windows and packages.json to circumvent a bug caused by upgrading to node 18+. Changed from pull request #711 to facillitate rebase onto the dev branch

Fixes #REPLACE_ME_WITH_THE_ISSUE_IF_EXISTS

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@Bdegraaf1234 Bdegraaf1234 changed the base branch from master to dev September 8, 2023 07:51
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Sep 8, 2023
Closed
5 tasks
blootsvoets
blootsvoets previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Sep 11, 2023
Merged
5 tasks
blootsvoets
blootsvoets previously approved these changes Sep 11, 2023
View reviewed changes
blootsvoets
blootsvoets reviewed Sep 11, 2023
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@blootsvoets blootsvoets merged commit 7cfa600 into dev Sep 12, 2023
4 of 5 checks passed
@blootsvoets blootsvoets deleted the fix/build_issues_windows_os2 branch September 12, 2023 11:26
@blootsvoets blootsvoets mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets left review comments

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bdegraaf1234 @blootsvoets