707 add print button to pair dialog #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be printed. I want to see if I can get this dynamic, since now these elements can never be printed using printscreen
printservice sets printlock from subject-pair-dialog.component.ts printlock is read from main.component.html. This needs a timeout in the print function call, hoping to resolve that still.
Bdegraaf1234
commented
Sep 15, 2023
src/main/webapp/app/shared/subject/subject-pair-dialog.component.ts
Outdated
Show resolved
Hide resolved
Bdegraaf1234
requested review from
nivemaham and
blootsvoets
as code owners
removed commented out code removed unused references to _print.scss removed unused print tag
blootsvoets
previously approved these changes
Sep 18, 2023
src/main/webapp/app/entities/project/project-detail.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/subject/subject-pair-dialog.component.ts
Outdated
Show resolved
Hide resolved
force angular to detect style changes by introducing a 0 ms timeout in setPrintLockTo remove unused references
|
final printview: |
blootsvoets
reviewed
Sep 18, 2023
blootsvoets
approved these changes
Sep 18, 2023
This was referenced Sep 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding a print button to the subject-pair dialogue.
Fixes #707
Checklist: