Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Decrease build size by over 80% #332

Merged
merged 1 commit into from Sep 21, 2018
Merged

Decrease build size by over 80% #332

merged 1 commit into from Sep 21, 2018

Conversation

AlQuraian
Copy link

Hi RADAR team..

After checking the build size I noticed that it's unusually large. So, I looked into the build configs and used the default Angular CLI configs, which has reduced the overall build size by more than 80%.

Here's the build info pre:

Date: 2018-09-05T14:03:08.688Z
Hash: 8af38acff19028a7ca41
Time: 48220ms
chunk {main} main.js, main.js.map (main) 770 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 268 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 5.22 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 157 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 6.23 MB [initial] [rendered]

Post:

Date: 2018-09-05T14:06:55.460Z
Hash: a8286514609e929f5352
Time: 48961ms
chunk {0} runtime.a66f828dca56eeb90e02.js (runtime) 1.05 kB [entry] [rendered]
chunk {1} styles.081da6090c7efb97781a.css (styles) 110 kB [initial] [rendered]
chunk {2} polyfills.d9eea419c90c39d2bdde.js (polyfills) 64.3 kB [initial] [rendered]
chunk {3} main.a2b8e8f0e19cb1b7f589.js (main) 1.09 MB [initial] [rendered]

@afolarin
Copy link
Member

afolarin commented Sep 5, 2018

Thanks! This project is under heavy development
cc/ @mpgxvii

@nivemaham nivemaham self-requested a review September 11, 2018 08:41
Copy link
Member

@nivemaham nivemaham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @AlQuraian . LGTM.

@mpgxvii
Copy link
Member

mpgxvii commented Sep 14, 2018

Thanks. LGTM.

@nivemaham I've fixed the failing Travis CI build. It was failing because of the security restrictions of Travis CI. This disallows forks from accessing encrypted env variables (tokens, etc). I've pushed the commit to a different (our own) branch to trigger the new 'trusted' build.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1960

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.185%

Totals Coverage Status
Change from base Build 1957: 0.0%
Covered Lines: 1387
Relevant Lines: 1597

💛 - Coveralls

@mpgxvii mpgxvii changed the base branch from develop to enhancement/decrease-build-size September 21, 2018 13:11
@mpgxvii mpgxvii merged commit abbc526 into RADAR-base:enhancement/decrease-build-size Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants