Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalBroadcastManager will broadcast the location change #436

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

this-Aditya
Copy link
Member

@this-Aditya this-Aditya commented Aug 24, 2023

  • Added feature to broadcast location changes by PhoneLocationManager

{ LocalBroadcastManager Dependencies are added as it was not imported by default. }
{ Constant DEVICE_LOCATION_CHANGE is in the GooglePlaces Plugin. }

@this-Aditya this-Aditya changed the title LocalBroadcastManager will broadcast at location change LocalBroadcastManager will broadcast the location change Aug 24, 2023
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with it, but what is the use case? If you want to reuse the value, then it makes sense to add a bundle with the corresponding location value.

@this-Aditya
Copy link
Member Author

Hi, in the Google Places plugin, the processPlacesData() function sends data in two cases:

  1. Every 600 seconds.
  2. When the device's location changes.

The device's location change is broadcast from here. In this case, we don't want to reuse the value; we simply need to find the places info.

Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright that makes sense. LGTM

@this-Aditya
Copy link
Member Author

Thanks.

@this-Aditya this-Aditya merged commit 8c6c6b7 into RADAR-base:dev Nov 1, 2023
2 checks passed
@this-Aditya this-Aditya deleted the location-broadcast branch April 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants