User empty object print ValueError #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohammadamint - I added a new method and fixed a bug in Appliance comparison I found while playing around with Appliances to test your fix |
Bachibouzouk
force-pushed
the
review_empty_object__repr__
branch
from
333cffe
to
40649d9
Compare
FLomb
approved these changes
Apr 12, 2024
Bachibouzouk
force-pushed
the
review_empty_object__repr__
branch
from
40649d9
to
3bf442d
Compare
issue: When a user object is empty cannot be printed due as the __repr__ method uses the save() method to print the properties of the users, which raise Exception in case no appliances are added to the user. solution: in case save() methods returns an exception, the function prints the user_name, and user_num with a message to mention no appliances are assigned to the user object yet.
The comparisons were not saved so the return value was always "True"
Bachibouzouk
force-pushed
the
review_empty_object__repr__
branch
from
3bf442d
to
7308029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
When a user object is empty cannot be printed due as the repr method uses the save() method to print the properties of the users, which raise Exception in case no appliances are added to the user.
solution:
in case save() methods returns an exception, the function prints the user_name, and user_num with a message to mention no appliances are assigned to the user object yet.
additional:
__eq__method ofApplianceclass and fixed itApplianceinstances to theadd_appliancemethod of theUserclass