Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving the readthedocs template #137

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

mohammadamint
Copy link
Collaborator

@mohammadamint mohammadamint commented May 1, 2024

Within the current template, 'basicstrap', the navigation on the left sidebar (with the partial TOC) is a bit counter-intuitive. The new template provides a more intuitive sidebars.

To test, make sure new theme is installed through installing docs-requirements.txt in the docs directory:

pip install -r docs-requirements.txt

within the current template, 'basicstrap', the navigation on the left sidebar (with the partial TOC) is a bit
counter-intuitive. The new template provides a more intituitive
sidebars.
Copy link
Collaborator

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding a nice theme and implementing it @mohammadamint !

I approved the PR but let us wait the approval of the JOSS reviewer before merging this into joss-review

I modified the notebook_converts.py script such that the notebooks are automatically converted to .rst upon build of the docs and that a link to download the .ipynb file is available directly into the RTD

@Bachibouzouk Bachibouzouk merged commit 56d9c81 into joss-paper May 7, 2024
1 check passed
@Bachibouzouk Bachibouzouk deleted the review_doc_template branch May 7, 2024 16:02
@Bachibouzouk Bachibouzouk restored the review_doc_template branch May 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants