introduce a BOM #222
Merged
introduce a BOM #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
added a commit
that referenced
this pull request
May 17, 2021
realdadfish
reviewed
May 17, 2021
| @@ -363,16 +363,19 @@ dependencies { | |||
| // core coroutines | |||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.3") | |||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.3") | |||
|
|
|||
| // a BOM ensures that all artifacts used from the library are of the same version | |||
| implementation(platform("com.rickbusarow.dispatch:dispatch-bom:1.0.0-RC01")) | |||
There was a problem hiding this comment.
Nit: You might want to tell the people that they have to add the platform tag to other configurations as well, i.e. testImplementation and androidTestImplementation. This alone is of course not very useful and saves no writing, however, people can set up their own "production" or "test" Java platform, import your BOM there and reference this here, so all their production / test dependencies are refererenced in a unified matter.
There was a problem hiding this comment.
Oh wait, testImplementation actually inherits implementation, ignore me... I was thinking about kapt and others for a moment. All good on your side :)
There was a problem hiding this comment.
:) Thanks. I plan to update all of this documentation before the 1.0 release. I know it's pretty lacking.
RBusarow
added a commit
that referenced
this pull request
May 25, 2021
* Bump com.diffplug.spotless from 5.12.4 to 5.12.5 (#220) * introduce a BOM (#222) * introduce a BOM * update main project README * Revert "introduce a BOM (#222)" (#224) This reverts commit ddf205a. * Bump io.gitlab.arturbosch.detekt from 1.16.0 to 1.17.0 (#226) Bumps io.gitlab.arturbosch.detekt from 1.16.0 to 1.17.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump io.gitlab.arturbosch.detekt from 1.17.0 to 1.17.1 (#228) Bumps io.gitlab.arturbosch.detekt from 1.17.0 to 1.17.1. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dependency updates - detekt 1.17.1 - JUnit 5.7.2 - Kotest 4.6.0 - Kotlin 1.5.10 - Androidx AppCompat 1.3.0 - Androidx core-ktx 1.5.0 - Androidx Fragment 1.3.4 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
RBusarow
added a commit
that referenced
this pull request
Jun 4, 2021
* dependency updates (#221) * dependency updates - AGP 4.2.1 - coroutines 1.5.0 - spotless 5.12.5 * update artifact versions in documentation samples Signed-off-by: GitHub Actions <actions@github.com> * Dispatch bom (#225) * Bump com.diffplug.spotless from 5.12.4 to 5.12.5 (#220) * introduce a BOM * update main project README Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dependency updates (#229) * Bump com.diffplug.spotless from 5.12.4 to 5.12.5 (#220) * introduce a BOM (#222) * introduce a BOM * update main project README * Revert "introduce a BOM (#222)" (#224) This reverts commit ddf205a. * Bump io.gitlab.arturbosch.detekt from 1.16.0 to 1.17.0 (#226) Bumps io.gitlab.arturbosch.detekt from 1.16.0 to 1.17.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump io.gitlab.arturbosch.detekt from 1.17.0 to 1.17.1 (#228) Bumps io.gitlab.arturbosch.detekt from 1.17.0 to 1.17.1. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dependency updates - detekt 1.17.1 - JUnit 5.7.2 - Kotest 4.6.0 - Kotlin 1.5.10 - Androidx AppCompat 1.3.0 - Androidx core-ktx 1.5.0 - Androidx Fragment 1.3.4 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove JUnit from the dispatch-test classpath (#232) fixes #231 * stop generating a BuildConfig in the Android modules (#234) fixes #233 * fix coroutineScope cancellation with withViewLifecycle (#237) * change version to 1.0.0-beta10 * update CHANGELOG * change library version in docs from RC01 to beta10 * add use of the BOM to junit readmes Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #219