Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable tangleViewModel function misses arguments the underlying activity isn't AppCompatActivity #228

Closed
RBusarow opened this issue Aug 31, 2021 · 0 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@RBusarow
Copy link
Owner

When using a Composable inside an Activity (without Fragments), the function checks whether the ViewModelStoreOwner is an AppCompatActivity instead of just a ComponentActivity.

When using Fragments, it checks if the current Activity is an AppCompatActivity instead of just a FragmentActivity.

If these conditions aren't met, then it skips the injected factory and tries to create the ViewModel using the default factory.

@RBusarow RBusarow added the bug Something isn't working label Aug 31, 2021
RBusarow added a commit that referenced this issue Aug 31, 2021
fixes #227
fixes #228
@kodiakhq kodiakhq bot closed this as completed in #247 Aug 31, 2021
kodiakhq bot pushed a commit that referenced this issue Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant