Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v27.1 is NOT 1.41.1 MSRV because of ureq #95

Closed
DanGould opened this issue Oct 29, 2022 · 4 comments
Closed

v27.1 is NOT 1.41.1 MSRV because of ureq #95

DanGould opened this issue Oct 29, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@DanGould
Copy link

DanGould commented Oct 29, 2022

ureq = "1.0" allows ureq 1.6 to be installed. 1.6 depends on once_cell v1.16.0 which is not msrv 1.41.1. once_cell 1.9.0 is te latest version of at msrv 1.41.1. once_cell 1.10.0 breaks it.

Unfortunately, ureq does not adhere to any MSRV, and only specifies once_cell = "1"

it seems this crate only has 1 ureq call, here https://github.com/RCasatta/bitcoind/blob/2c1758a2d5d638a388906c97bc011802b12e498b/build.rs#L106

so maybe the whole dependency could be replaced with something that maintains an MSRV

This is causing problems downstream. Kixunil/payjoin#36

@RCasatta RCasatta added the bug Something isn't working label Oct 30, 2022
@RCasatta
Copy link
Collaborator

Any suggestion to adhere to MSRV on 27.x branch is welcome

nickfarrow added a commit to nickfarrow/bitcoind that referenced this issue Nov 8, 2022
Use reqwest version 0.10 (MSRV of 1.39.0) to resolve MSRV issue rust-bitcoin#95
@DanGould
Copy link
Author

Even with cargo update -p once_cell --precise 1.9.0 and building ureq in isolation msrv appears to be 1.54 for ureq 1.9.0. Further investigation is required.

@RCasatta
Copy link
Collaborator

RCasatta commented Jan 5, 2023

@DanGould have a look at #102 which is a compromise, it allows MSRV 1.41.1 if the auto-download feature is not used

@RCasatta
Copy link
Collaborator

#102 (comment) I think it's solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants