returning an error if the subprocess failed early #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RCasatta
reviewed
Feb 2, 2022
There was a problem hiding this comment.
This is nice, I added an issue to implement this also for bitcoind crate rust-bitcoin/bitcoind#50
src/lib.rs
Outdated
|
|
||
| let client = loop { | ||
| if let Some(status) = process.try_wait()? { | ||
| debug!("early exit with: {:?}", status); |
There was a problem hiding this comment.
What do you think to use warn! or error! instead of debug!?
ulrichard
force-pushed
the
feature/zombie
branch
from
3826d81
to
9b76740
Compare
RCasatta
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns an error if the electrsd sub-process failed early.
Without this change, it would end in an infinite loop as described in #31