-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pilot3 programs for .zip build+run with pilot3utils namespace and library reference #40
Comments
Hi, @robertdevine I just saw this. Do you suggest we do all of the testing from this branch before we move to main? I was about to run the copy script in anyone have a preference? |
Just to save time, I went ahead and just copied everything to this branch. When doing testing and downloading the eCTD pilot 3 submission structure, please make sure to switch to this 40 branch first, then download the .zip. The adrg.pdf in the m5 should also be the latest and updated. Fixed the layouts and manually fixed the wrapping. Test away!!! |
Roger roger! |
Hi @laxamanaj - yes, that branch selection should be appropriate. So far, the testing is going very well. During the testing if you start with the renv-lock.txt from the Installation Instructions issue (closed earlier today) then snapshot to install pilot3utils your test sandbox actually matches what we have been doing here - so, in summary, using the branch you identified here to complete the tests prior to merge onto main should be fine. I have run into no issues -including fast forwarding all code changes into the latest source changes. thx |
@laxamanaj , @bms63 - just to be certain pilot3 team is aware the difference between the .txt lock provided with the Installation Instructions - the slight difference is due to the snapshot when the {pilot3utils} package gets appended to the lock during the installation process. A nuance of difference to be aware of since the actual {pilot3utils} package dependency appears in the proprietary pilot3 lock file for folks cloning, forking, sub-modeling, etc. thx. |
I think pilto3utils in renv.lock file could use a refresh - pilto3utils should be Version |
Thx. @bms63 All programs/outputs run successfully. I'll issue the PR. thx. again. |
Thanks Robert!! |
…-zip-build+run-with-pilot3utils-namespace-and-library-reference Closes #40 update pilot3 programs for zip build+run with pilot3utils namespace and library reference
With the .zip package installation instructions, the programs need updated reference to the package namespace and library for build and run. See here for details. thx.
The text was updated successfully, but these errors were encountered: