Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added response letter #163

Merged
merged 12 commits into from
Apr 12, 2024
Merged

added response letter #163

merged 12 commits into from
Apr 12, 2024

Conversation

SHAESEN2
Copy link
Collaborator

@SHAESEN2 SHAESEN2 commented Mar 1, 2024

Closes issue #149

@SHAESEN2 SHAESEN2 requested a review from laxamanaj March 1, 2024 08:43
@bms63
Copy link
Collaborator

bms63 commented Mar 10, 2024

Is the Response Letter title appropriate for this update? I think this is needed for the website - just the Response Letter is something different to me.

@laxamanaj
Copy link
Collaborator

laxamanaj commented Apr 9, 2024

Pilot3_response_to_fda.pdf
Hi, Team.
I have updated the response letter to follow similar format as Pilot 1 team response letter as I've referenced here : https://github.com/RConsortium/submissions-pilot1-to-fda/blob/main/m1/us/response-to-fda-1.pdf

Thanks, @SHAESEN2 for starting this off. All, if you have a chance to review this letter, please comment or approve your review by EOD tomorrow (or today if your in EU timezone).

I am contemplating whether or not remove the comment 1 feedback and response as this was more of just referencing other sources from past R consortium discussions or other on-line research. Let me know what you guys think. I know I've update this response letter as now a developer instead of reviewer, but @SHAESEN2 if the updated letter sounds, looks good to you, I can approve review on my end. Just comment here as such. Thanks all. Let's wrap this up.

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Just a few notes.

Copy link
Collaborator Author

@SHAESEN2 SHAESEN2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @laxamanaj can you make sure that the text wraps on the page? In the posit cloud editor you will see a line in the console indicating the end of a page. It does not seem an issue when I render in the posit cloud but I had issues on our internal linux R system.

image

@SHAESEN2
Copy link
Collaborator Author

No further comments ! Looks good :) Thanks @laxamanaj

laxamanaj and others added 6 commits April 11, 2024 04:26
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
updated

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Merge branch '149-explore-differences' of github.com:RConsortium/submissions-pilot3-adam into 149-explore-differences

# Conflicts:
#	vignettes/response-FDA IR-pilot3.qmd
@laxamanaj
Copy link
Collaborator

Hey @laxamanaj can you make sure that the text wraps on the page? In the posit cloud editor you will see a line in the console indicating the end of a page. It does not seem an issue when I render in the posit cloud but I had issues on our internal linux R system.

image

This is updated now, @SHAESEN2 . Thanks.

@laxamanaj
Copy link
Collaborator

I believe I've responded to all of your comments. The qmd has been pushed now.

@SHAESEN2 feel free to update further to resolve the comments from @bms63 .

Copy link
Collaborator

@laxamanaj laxamanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated per team feedback.

@laxamanaj laxamanaj merged commit 698a8d6 into main Apr 12, 2024
5 checks passed
@laxamanaj laxamanaj deleted the 149-explore-differences branch April 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants