Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #170 Clean up: Removes adrg_image folder, old spec references, duplicate image, website update #171

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Closes #170 Clean up: Removes adrg_image folder, old spec references, duplicate image, website update #171

merged 2 commits into from
Mar 22, 2024

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Mar 22, 2024 •
edited
Loading

Hi all,

Just doing a bit of cleaning up:

  • Removed adrg_images folder and moved single image to images folder
  • Removed duplicated study design image
  • Updated website vignettes to use current spec name
  • Updated website to use current pdf

@bms63 bms63 linked an issue Mar 22, 2024 that may be closed by this pull request
Ben's Findings: Remove duplicated image, re-run pdf #170
Closed
@bms63 bms63 changed the title Closes #170 Removes adrg_image folder, old spec references Closes #170 Clean up: Removes adrg_image folder, old spec references, duplicate image, website update Mar 22, 2024
bms63
bms63 commented Mar 22, 2024
View reviewed changes
Copy link
Collaborator Author

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make another pass on the ADRG later, but just wanted to clean up some of this stuff.

@laxamanaj
Copy link
Collaborator

Hi all,

Just doing a bit of cleaning up:

  • Removed adrg_images folder and moved single image to images folder
  • Removed duplicated study design image
  • Updated website vignettes to use current spec name
  • Updated website to use current pdf

Perfect! Thanks @bms63 . These actions sound good to me.

laxamanaj
laxamanaj approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@laxamanaj laxamanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good updates. Thanks, @bms63 .

@laxamanaj laxamanaj merged commit c48145f into main Mar 22, 2024
5 checks passed
@laxamanaj laxamanaj deleted the 170-bens-findings-remove-duplicated-image-re-run-pdf branch March 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxamanaj laxamanaj laxamanaj approved these changes

@robertdevine robertdevine Awaiting requested review from robertdevine

@AlexandraP-21 AlexandraP-21 Awaiting requested review from AlexandraP-21

@SHAESEN2 SHAESEN2 Awaiting requested review from SHAESEN2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ben's Findings: Remove duplicated image, re-run pdf
2 participants
@bms63 @laxamanaj