Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to spec file 'Variables tab, Format column, ADTTE Dataset rows for SAS-compatible xportr_write in adtte.R #90

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

robertdevine
Copy link
Collaborator

Updates to spec file 'Variables tab, Format column, ADTTE Dataset rows (non DATE9. type)' to facilitate SAS compatible xportr_write without explicit call to xportr_format maintaining consistency across Pilot3 Datasets.

…s (non DATE9. type)' to facilitate SAS compatible xportr_write without explicit call to xportr_format maintaining consistency across Pilot3 Datasets.
@robertdevine robertdevine linked an issue Mar 27, 2023 that may be closed by this pull request
Copy link
Collaborator

@DeclanHodges DeclanHodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertdevine, the spec update looks good to me and I can confirm also that ADTTE code is running smoothly now. Thanks again for resolving this!

@DeclanHodges
Copy link
Collaborator

@laxamanaj or @thomas-neitmann - are you okay to merge this PR?

@laxamanaj
Copy link
Collaborator

Thanks for the updates @robertdevine and for reviewing, @DeclanHodges . Yes, will merge now.

@laxamanaj laxamanaj merged commit 4ac5e91 into main Mar 28, 2023
@laxamanaj laxamanaj deleted the 89-adtte-xportr_write-call-error branch March 28, 2023 22:20
@laxamanaj laxamanaj mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADTTE xportr_write() Call Error
4 participants