test: add webtest marker to tests that use the internet
#2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20230319T2227-no_internet
branch
4 times, most recently
from
2986ca0
to
21d5693
Compare
This is being done so that it is easier for downstream packagers to run the test suite without requiring internet access. To run only tests that does not use the internet, run `pytest -m "not webtest"`. The validation workflow validates that test run without internet access by running the tests inside `firejail --net=none`. - Closes <RDFLib#2293>.
aucampia
force-pushed
the
iwana-20230319T2227-no_internet
branch
from
21d5693
to
3bf44f9
Compare
|
Hopefully the coverage remains the same, if it does, then I guess we can go with this. |
|
Okay, coverage remains the same, so I think this is good to go. I did this now, mainly so that it is less annoying for downstream to package our releases. |
aucampia
added
review wanted
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is being done so that it is easier for downstream packagers to run the test
suite without requiring internet access.
To run only tests that does not use the internet, run
pytest -m "not webtest".The validation workflow validates that test run without internet access by
running the tests inside
firejail --net=none.Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.