fix: JSON-LD context construction from a dict
#2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsolbrig please have a look if you have time, I think you know this code better than most. |
aucampia
force-pushed
the
iwana-20230322T2346-fix_jsonld_context
branch
from
08e9a68
to
73fd02e
Compare
aucampia
added
review wanted
A variable was only being initialized for string-valued inputs, but if a `dict` input was passed the variable would still be accessed, resulting in a `UnboundLocalError`. This change initializes the variable always, instead of only when string-valued input is used to construct a JSON-LD context. - Closes <RDFLib#2303>.
aucampia
force-pushed
the
iwana-20230322T2346-fix_jsonld_context
branch
from
73fd02e
to
f2da44a
Compare
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A variable was only being initialized for string-valued inputs, but if a
dictinput was passed the variable would still be accessed, resulting in aUnboundLocalError.This change initializes the variable always, instead of only when string-valued input is used to construct a JSON-LD context.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.