Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add to_dict method to the JSON-LD Context class. #2310

Merged
merged 2 commits into from Mar 25, 2023
Merged

fix: Add to_dict method to the JSON-LD Context class. #2310

merged 2 commits into from Mar 25, 2023

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Mar 24, 2023 •
edited

Summary of changes

Context.to_dict is used in JSON-LD serialization, but it was not implemented.
This change adds the method.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

maparent and others added 2 commits March 24, 2023 19:56
@maparent @aucampia
implementation of the to_dict method on a context
f417eb7
@aucampia
fix: Add to_dict method to the JSON-LD Context class.
79fbd9b 
`Context.to_dict` is used in JSON-LD serialization, but it was not implemented.
This change adds the method.
@aucampia aucampia force-pushed the iwana-20230323T2054-context_to_dict branch from 73a731e to 79fbd9b Compare March 24, 2023 20:04
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 24, 2023
@aucampia aucampia marked this pull request as ready for review March 24, 2023 20:04
@aucampia aucampia requested a review from a team March 24, 2023 20:04
@coveralls
Copy link

Coverage Status

Coverage: 90.807% (+0.02%) from 90.792% when pulling 79fbd9b on aucampia:iwana-20230323T2054-context_to_dict into 832e693 on RDFLib:main.

ghost
ghost approved these changes Mar 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aucampia aucampia merged commit d7883eb into RDFLib:main Mar 25, 2023
23 checks passed
@aucampia aucampia deleted the iwana-20230323T2054-context_to_dict branch April 9, 2023 15:04
This was referenced Jul 6, 2023
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[json-ld serialisation] Context.to_dict() is not implemented (anymore?)
3 participants
@aucampia @coveralls @maparent