Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reference to global inside get_target_namespace_elements #2311

Merged
merged 1 commit into from Mar 25, 2023
Merged

fix: reference to global inside get_target_namespace_elements #2311

merged 1 commit into from Mar 25, 2023

Conversation

aucampia
Copy link
Member

Summary of changes

get_target_namespace_elements references the args global, which is not defined if the function is called from outside the module. This commit fixes that instead referencing the argument passed to the function.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia
fix: reference to global inside get_target_namespace_elements
d3a59c2 
`get_target_namespace_elements` references the `args` global, which is not
defined if the function is called from outside the module. This commit fixes
that instead referencing the argument passed to the function.

- Closes <RDFLib#2072>.
@aucampia aucampia marked this pull request as ready for review March 24, 2023 21:30
@aucampia aucampia requested a review from a team March 24, 2023 21:30
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 24, 2023
@coveralls
Copy link

Coverage Status

Coverage: 90.792%. Remained the same when pulling d3a59c2 on aucampia:iwana-20230324T2228-fix_dnc into 832e693 on RDFLib:main.

ghost
ghost approved these changes Mar 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 4da67f9 into RDFLib:main Mar 25, 2023
23 checks passed
@aucampia aucampia deleted the iwana-20230324T2228-fix_dnc branch April 9, 2023 15:04
This was referenced Jul 6, 2023
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

function call fails as there is a reference to args.target_namespace which I believe shoud be target_namespace
2 participants
@aucampia @coveralls