Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore the 6.1.1 default bound namespaces #2313

Merged
merged 1 commit into from Mar 26, 2023

Conversation

aucampia
Copy link
Member

Summary of changes

The namespaces bound by default by rdflib.graph.Graph and rdflib.namespace.NamespaceManager was reduced in version 6.2.0 of RDFLib, however, this also would cause code that worked with 6.1.1 to break, so this constituted a breaking change. This change restores the previous behaviour, binding the same namespaces as was bound in 6.1.1.

To bind a reduced set of namespaces, the bind_namespaces parameter of rdflib.graph.Graph or rdflib.namespace.NamespaceManager can be used.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia marked this pull request as ready for review March 25, 2023 18:19
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 25, 2023
@aucampia aucampia requested a review from a team March 25, 2023 18:19
@aucampia aucampia force-pushed the iwana-20230325T1842-default_prefixes branch from 1634409 to 5961ddf Compare March 25, 2023 19:02
@coveralls
Copy link

coveralls commented Mar 25, 2023

Coverage Status

Coverage: 90.807%. Remained the same when pulling 1fe112e on aucampia:iwana-20230325T1842-default_prefixes into 4da67f9 on RDFLib:main.

The namespaces bound by default by `rdflib.graph.Graph` and
`rdflib.namespace.NamespaceManager` was reduced in version 6.2.0 of RDFLib,
however, this also would cause code that worked with 6.1.1 to break, so this
constituted a breaking change. This change restores the previous behavior,
binding the same namespaces as was bound in 6.1.1.

To bind a reduced set of namespaces the `bind_namespaces` parameter of
`rdflib.graph.Graph` or `rdflib.namespace.NamespaceManager` can be used.

- Closes <RDFLib#2103>.
@aucampia aucampia force-pushed the iwana-20230325T1842-default_prefixes branch from 5961ddf to 1fe112e Compare March 26, 2023 08:28
@aucampia aucampia merged commit 57bb428 into RDFLib:main Mar 26, 2023
23 checks passed
@aucampia aucampia deleted the iwana-20230325T1842-default_prefixes branch April 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dcterms no longer included among default namespaces in 6.2.0
2 participants