Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions #2314

Merged
merged 1 commit into from Mar 26, 2023
Merged

fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions #2314

merged 1 commit into from Mar 26, 2023

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Mar 25, 2023 •
edited

Summary of changes

ROUND was not correctly rounding negative numbers towards positive infinity, ENCODE_FOR_URI incorrectly treated / as safe, and SECONDS did not include fractional seconds.

This change corrects these issues.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20230325T2326-fix_sparql_functions branch from c834a76 to 97f81f3 Compare March 25, 2023 22:29
@aucampia
fix: ROUND, ENCODE_FOR_URI and SECONDS SPARQL functions
c7db012 
`ROUND` was not correctly rounding negative numbers towards positive infinity,
`ENCODE_FOR_URI` incorrectly treated `/` as safe, and `SECONDS` did not include
fractional seconds.

This change corrects these issues.

- Closes <RDFLib#2151>.
@aucampia aucampia force-pushed the iwana-20230325T2326-fix_sparql_functions branch from 97f81f3 to c7db012 Compare March 25, 2023 22:43
@aucampia aucampia marked this pull request as ready for review March 25, 2023 22:49
@coveralls
Copy link

Coverage Status

Coverage: 90.838% (+0.03%) from 90.807% when pulling c7db012 on aucampia:iwana-20230325T2326-fix_sparql_functions into 4da67f9 on RDFLib:main.

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 25, 2023
@aucampia aucampia requested a review from a team March 25, 2023 23:37
@aucampia aucampia merged commit af17916 into RDFLib:main Mar 26, 2023
23 checks passed
@aucampia aucampia deleted the iwana-20230325T2326-fix_sparql_functions branch April 9, 2023 15:04
This was referenced Jul 6, 2023
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENCODE_FOR_URI bug?
2 participants
@aucampia @coveralls