Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct imports and __all__ #2340

Merged
merged 1 commit into from Apr 12, 2023

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Apr 9, 2023

Summary of changes

Disable
implicit_reexport
and eliminate all errors reported by mypy after this.

This helps ensure that import statements import from the right module and that
the __all__ variable is correct.

These changes caused some Sphinx warnings (which are treated as errors) as
Sphinx is not happy if the namespaces are documented in two places. An example
of one of these errors are:

WARNING: duplicate object description of rdflib.namespace._BRICK.BRICK, other instance in apidocs/rdflib, use :noindex: for one of them

To mitigate this the Sphinx config is updated to ignore the namespaces when
generating docs for apidocs/rdflib.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20230409T2218-fix_all branch from f5fa46e to c96e5ff Compare April 10, 2023 14:08
Disable
[`implicit_reexport`](https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport)
and eliminate all errors reported by mypy after this.

This helps ensure that import statements import from the right module and that
the `__all__` variable is correct.
@aucampia aucampia force-pushed the iwana-20230409T2218-fix_all branch from c96e5ff to 3113991 Compare April 10, 2023 14:11
@coveralls
Copy link

Coverage Status

Coverage: 90.839% (+0.0009%) from 90.838% when pulling 3113991 on aucampia:iwana-20230409T2218-fix_all into 5c3c78a on RDFLib:main.

@aucampia aucampia marked this pull request as ready for review April 10, 2023 15:01
@aucampia aucampia requested a review from a team April 10, 2023 15:01
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Apr 10, 2023
@aucampia aucampia merged commit 7df77cd into RDFLib:main Apr 12, 2023
25 checks passed
@aucampia aucampia deleted the iwana-20230409T2218-fix_all branch June 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants