Fix docs comment doesn't describe behavior #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment refers to a person that knows bob and code would return a name, but this would only work if the triple `person foaf:name bob .` is part of the dataset. As this is a very uncommon way to model a `foaf:knows` the code was adjusted to match the description.
The code in docs won't always be complete programs and is sometimes just snippets, and for snippets it does not make sense to error out if the variables used in the snippet is not defined.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment refers to a person that knows bob and code would return a name, but this would only work if the triple
person foaf:name bob .is part of the dataset. As this is a very uncommon way to model a
foaf:knowsthe code was adjusted to match the description.