fix: typing errors from dmypy #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
added
review wanted
aucampia
force-pushed
the
aucampia/20230618T2354-dmypy
branch
2 times, most recently
from
43bdb25
to
edc6d7e
Compare
Fix various typing errors that are reported when running with `dmypy`, the mypy daemon. Also add a task for running `dmypy` to the Taskfile that can be selected as the default mypy variant by setting the `MYPY_VARIANT` environment variable to `dmypy`.
aucampia
force-pushed
the
aucampia/20230618T2354-dmypy
branch
from
edc6d7e
to
e5c8fcb
Compare
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix various typing errors that are reported when running with
dmypy, the mypy daemon.Also add a task for running
dmypyto the Taskfile that can be selected as the default mypy variant by setting theMYPY_VARIANTenvironment variable todmypy.Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.