Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test and bugfix for the custom groupconcat separator "" (issue#2473) #2474

Merged
merged 2 commits into from Jul 8, 2023

Conversation

WhiteGobo
Copy link
Contributor

@WhiteGobo WhiteGobo commented Jul 7, 2023

Summary of changes

added test for this case
added bugfix for missing separator in groupconcat
groupconcat checked with generic bool if default " " should be used.Now it checks if aggregator has set separator not None

Also added some annotations

Bugfix for this issue

Fixes #2473

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

added bugfix for missing separator in groupconcat
@coveralls
Copy link

coveralls commented Jul 7, 2023

Coverage Status

coverage: 90.904% (+0.001%) from 90.903% when pulling d6ed5f2 on WhiteGobo:bug_groupconcat_uses_separator into 0ea6ca5 on RDFLib:main.

@WhiteGobo WhiteGobo changed the title added test and bugfix for the custom groupconcat separator "" (issue#1793405686) added test and bugfix for the custom groupconcat separator "" (issue#2473) Jul 7, 2023
@aucampia
Copy link
Member

aucampia commented Jul 8, 2023

pre-commit.ci autofix

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @WhiteGobo, changes look good.

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Jul 8, 2023
@aucampia aucampia requested a review from a team July 8, 2023 20:34
@aucampia aucampia merged commit e94c252 into RDFLib:main Jul 8, 2023
22 checks passed
@WhiteGobo WhiteGobo deleted the bug_groupconcat_uses_separator branch July 10, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separator in group_concat function with explicit empty string incorrectly defaults to 'space' character
3 participants