fix: handling of rdf:HTML literals
#2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if without `html5lib` installed, literals with`rdf:HTML` datatypes were treated as [ill-typed](https://www.w3.org/TR/rdf11-concepts/#section-Graph-Literal), even if they were not ill-typed. With this change, if `html5lib` is not installed, literals with the `rdf:HTML` datatype will not be treated as ill-typed, and will have `Null` as their `ill_typed` attribute value, which means that it is unknown whether they are ill-typed or not. This change also fixes the mapping from `rdf:HTML` literal values to lexical forms. Other changes: - Add tests for `rdflib.NORMALIZE_LITERALS` to ensure it behaves correctly. Related issues: - Fixes <RDFLib#2475>
aucampia
added
review wanted
|
@WhiteGobo if you have a moment for a review please have a look. |
|
Looks good to me. I find the idea to load the parser only if html5lib exists good. |
WhiteGobo
reviewed
Jul 16, 2023
WhiteGobo
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Previously, if without
html5libinstalled, literals withrdf:HTMLdatatypes were treated asill-typed, even if they were not ill-typed.
With this change, if
html5libis not installed, literals with therdf:HTMLdatatype will not be treated as ill-typed, and will haveNullas theirill_typedattribute value, which means that it is unknown whether they are ill-typed or not.This change also fixes the mapping from
rdf:HTMLliteral values to lexical forms.Other changes:
rdflib.NORMALIZE_LITERALSto ensure it behaves correctly.Related issues:
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.