Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longturtle improvements #2500

Merged
merged 12 commits into from Jul 25, 2023
Merged

Longturtle improvements #2500

merged 12 commits into from Jul 25, 2023

Conversation

nicholascar
Copy link
Member

@nicholascar nicholascar commented Jul 25, 2023

Summary of changes

Fixes some ugliness in the longturtle format, in particular:

  • double newline at the end of the file
  • inconsistent Blank Node bracket positions - some line training, some newlining, now all newline
  • Blank Node incorrect indentation - now they are all 1 indentation further right than their parents and their content is another further indent right

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • N/A
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@nicholascar nicholascar marked this pull request as ready for review July 25, 2023 16:05
@coveralls
Copy link

coveralls commented Jul 25, 2023

Coverage Status

coverage: 90.924% (-0.001%) from 90.925% when pulling 476c97b on longturtle_improve into b1ff089 on main.

@aucampia
Copy link
Member

pre-commit.ci autofix

@aucampia aucampia requested a review from a team July 25, 2023 18:58
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Jul 25, 2023
@nicholascar nicholascar merged commit 5ee8bd7 into main Jul 25, 2023
22 checks passed
@nicholascar nicholascar deleted the longturtle_improve branch July 25, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants