Fix for #298: [Android] Taps are not recognized + Hide ActionBar in fullscreen mode #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good that this is such a simple fix. Will merge as soon as the CI is done. |
|
ah dammit. I committed to early. |
ChaosMarc
changed the title
|
Why is that? Because I would have merged your PR too early? Just tell me when it's ready then :) |
|
you can merge when the CI is completed. I actually wanted to do the second fix in another branch but pushed to the wrong one ^^ edit: please merge 👼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some devices both events AINPUT_SOURCE_TOUCHSCREEN & AINPUT_SOURCE_STYLUS are triggered on tap/touch.
see SFML/SFML#953 for more details