-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation steps of OS-specific dependencies #247
Add installation steps of OS-specific dependencies #247
Conversation
Developed specifically to improve documentation in REditorSupport/languageserver#247
Failing the CI while there is no actual code change 😂
Something seems off... The package is there https://cran.r-project.org/web/packages/rlang/index.html but for R 4.0 while we fetch the package for R 3.6 https://cran.r-project.org/bin/macosx/contrib/ doesn't provide packages for R 3.6 |
ae3089d
to
a2e340c
Compare
@randy3k @renkun-ken Is there any reason not to merge this pull request? I think #487 is related to this (Linux users get confused trying to install the languageserver package without understanding the need for library installation). |
Not sure why we haven't merged this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dnf install --assumeyes --setopt=install_weak_deps=False @development-tools libcurl-devel libxml2-devel openssl-devel R | ||
|
||
# On Alpine | ||
apk add --no-cache curl-dev g++ gcc libxml2-dev linux-headers make R R-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also cover macOS if the package is built from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea ! I don't know what packages are needed on macOS, happy to add them if someone can provide them
We can also cover macOS in a subsequent pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS, the R dependencies are most likely to be installed from pre-built binary packages. So I think we don't need to put them here at the moment.
What does this PR do ?
Embed three changes, with the dependency commands being the most important one :
languageserver
packageMotivation
Second commit is here to help troubleshooting installation problems on common distros. As remote development becomes more common, installing a language server in a container should be as smooth as possible. See for instance https://code.visualstudio.com/docs/remote/containers
Third commit eases readability of the repo main page
Testing Guidelines
All tests were run inside docker images, as summarized in https://github.com/badouralix/dockerfiles/tree/master/r-languageserver
Besides missing compiling tools, namely three errors occurred with fairly easy fixes
All of them showed up when I ran the following command ( see
curl
,openssl
andxml2
dependencies )libcurl
libssl
libxml2