Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling raw string in link and color #274

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Fix handling raw string in link and color #274

merged 5 commits into from
Jun 11, 2020

Conversation

renkun-ken
Copy link
Member

Related #242

This PR

  • Fixes raw string handling in document link using col1 and col2 attributes of STR_CONST (which are correct) and parse() to extract the right text.
  • Ignores raw string in color provider to avoid incorrect replacement of color from color picker.
  • Adds test cases of handling raw strings in document link.

@renkun-ken renkun-ken requested a review from randy3k June 11, 2020 11:10
@randy3k
Copy link
Member

randy3k commented Jun 11, 2020

LGTM. Thanks for working on this.

@renkun-ken renkun-ken merged commit 48c608a into master Jun 11, 2020
@randy3k randy3k deleted the fix-raw-string branch August 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randy3k randy3k randy3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renkun-ken @randy3k