Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve xpath to work with cursor on token ending #311

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

renkun-ken
Copy link
Member

Close REditorSupport/vscode-R#379.

xdoc_find_token and xdoc_find_enclosing_scopes are improved to work with cursor in the end of the token, which is consistent with how other language servers deal with tokens (e.g. C++ language server works from both beginning and end).

@renkun-ken renkun-ken requested a review from randy3k July 13, 2020 02:32
@randy3k
Copy link
Member

randy3k commented Jul 13, 2020

Thank you for working on it.

@renkun-ken renkun-ken merged commit 958d8b7 into REditorSupport:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goto defination not work
2 participants