Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit string length to provide color and link #314

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

renkun-ken
Copy link
Member

Close #313.

For link provider, the string length is limited to 255 characters.

For color provider, the string length is limited from 3 (shorted color name, e.g. red) to 20 (longest color name, e.g. lightgoldenrodyellow).

@randy3k
Copy link
Member

randy3k commented Jul 24, 2020

perhaps it is worth to put down some comments.

@renkun-ken
Copy link
Member Author

perhaps it is worth to put down some comments.

What do you mean by "put down some comments"?

@randy3k
Copy link
Member

randy3k commented Jul 24, 2020

I meant to have some comments to explain the strange numbers like 256 or 20

@renkun-ken renkun-ken merged commit c89e30e into REditorSupport:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Languageserver crashes on long string (?)
2 participants