Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xpaths to adapt to token change in parse data in R 4.0 #328

Merged
merged 4 commits into from
Aug 30, 2020
Merged

Update xpaths to adapt to token change in parse data in R 4.0 #328

merged 4 commits into from
Aug 30, 2020

Conversation

renkun-ken
Copy link
Member

Close #327

LEFT_ASSIGN, RIGHT_ASSIGN, and EQ_ASSIGN are restrictive enough to limit the scope of the XPath selectors, so no need to specify their parent node.

randy3k
randy3k approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@randy3k randy3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. Looks good to me.

@renkun-ken renkun-ken merged commit dc81757 into REditorSupport:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randy3k randy3k randy3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

equal_assign changed to expr_or_assign_or_help in R 4.0
2 participants
@renkun-ken @randy3k