Do not load sysdata.rda #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a better solution may be to load only files end with |
I wanted to err on the side of conservativism, as there could also be extensions |
|
I updated the PR, if you would like to re-review. |
|
@randy3k Do we need to resolve the CI issue before merging? |
|
This one looks good to me. |
I don't think it makes sense to support all the ancient file types. Anyway, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the R directory, some packages have the
sysdata.rdafile (see https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Package-subdirectories for reference), which tries to get loaded on_initialized. This PR proposes to skip that file fromload_all().