Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #351

Merged
merged 12 commits into from
Oct 29, 2020
Merged

Fix tests #351

merged 12 commits into from
Oct 29, 2020

Conversation

randy3k
Copy link
Member

@randy3k randy3k commented Oct 28, 2020

  • update syntax for withr::local_tempfile

  • do not expect returns when shutting down server

  • need to retry in various places to fix the coverage tests because tests running with covr are slow

@randy3k randy3k changed the title attemp to fix tests [wip] attemp to fix tests Oct 28, 2020
@randy3k randy3k force-pushed the fixtests branch 2 times, most recently from 7de27ac to cf6d5d1 Compare October 28, 2020 07:56
@randy3k randy3k force-pushed the fixtests branch 2 times, most recently from f9c62a1 to a535351 Compare October 28, 2020 17:41
@randy3k randy3k force-pushed the fixtests branch 4 times, most recently from 70604bc to 9555fb0 Compare October 28, 2020 19:52
@randy3k randy3k changed the title [wip] attemp to fix tests Fix tests Oct 28, 2020
@renkun-ken
Copy link
Member

Nice work to make the CI runners succeed again!

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randy3k randy3k merged commit 865a4b9 into master Oct 29, 2020
@randy3k randy3k deleted the fixtests branch October 29, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants