Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty string instead of NULL as default signature doc #371

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Jan 26, 2021

With latest vscode-languageclient 7.0.0 used in vscode-r-lsp 0.1.14, the following code does not trigger SignatureHelp:

fun <- function(x, y) {
  x + y
}

fun(

It looks likedocumentation === null is no longer accepted by vscode-languageclient 7.0.0. The LSP says the following

documentation?: string | MarkupContent;

looks like documentation could not be null.

This PR is a simple fix and it works with latest vscode-r-lsp now.

@randy3k
Copy link
Member

randy3k commented Jan 26, 2021

LGTM

@renkun-ken renkun-ken merged commit e46efda into REditorSupport:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants