Use empty string instead of NULL as default signature doc #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest vscode-languageclient 7.0.0 used in vscode-r-lsp 0.1.14, the following code does not trigger SignatureHelp:
It looks like
documentation === null
is no longer accepted by vscode-languageclient 7.0.0. The LSP says the followinglooks like
documentation
could not benull
.This PR is a simple fix and it works with latest vscode-r-lsp now.