-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code action to disable linters #408
Conversation
I'd like to merge this PR to enable code actions to support only "Disable all linters for this line" before how lintr settles down how individual linters could be disabled. |
It makes sense to me to merge the PR. It will be great if you could come up with some tests though. |
Yes, I'm working on some test cases for this. |
This reverts commit 94c029d.
Not sure why windows check not passing. |
Looks like the windows build does not use the latest pushed version since the log does not contain the diagnostics in |
Looks like
|
LGTM |
This PR enables CodeAction and provides the following code actions:
# nolint
in the end of the line if a linter complains).Disablesome_linter
for this lineThere is an open discussion at r-lib/lintr#720 about disabling specific linters. In the future, we could add code action to disable specific linters that produce diagnostics for certain lines. The development version of lintr already supports disabling specific linters: