Only call fs::path_abs
with existing files
#506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to r-lib/fs#269, the known limitation of
fs
functions, it might make sense to only callfs::path_abs
only with existing files so that long strings that are not file paths are not passed to the function. In #502, it seems that even as we filter the string length, it might be possible that some long strings will still cause a problem. This PR checks the strings first and only callfs::path_abs()
with existing file paths.Here, the purpose we use
fs::path_abs()
is that we need to get an absolute path but not follow the symlinks.