Avoid emitting a negative activeSignature #586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in helix-editor/helix#5023,
languageserver
was emitting a-1
to a field that has the typeuinteger
.Specifically, a negative
activeSignature
was being emitted by default when no signatures are provided to asignatureHelp
request. The spec covers cases where an "out of range" value is emitted, but I don't think this is intended to cover negative values.As
activeSignature
is an optional field, I changed it so that the default is to leave the field unspecified. This has resolved the issue in the helix text editor's LSP listener.