Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing slash in code-server's URI template #1241

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Oct 27, 2022

What problem did you solve?

coder/code-server#5711 (comment)

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit 33e0ba9 into REditorSupport:master Oct 27, 2022
@benz0li
Copy link
Contributor Author

benz0li commented Oct 29, 2022

code-server v4.8.1 has been released, which suffixes VSCODE_PROXY_URI with a /.

When will v2.6.1 of the R extension be released – including this modification here?

@renkun-ken
Copy link
Member

v2.6.1 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants