Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken tasks problemMatcher regex #1257

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

gowerc
Copy link
Contributor

@gowerc gowerc commented Nov 11, 2022

What problem did you solve?

Problem matcher for testthat wasn't working as it doesn't always return a column. I updated the regex syntax to make capturing the column optional

(If you have)Screenshot

Example of testthat not returning a column number:
image

Updated Regex now capturing this error properly again:
image

@gowerc gowerc changed the title fixed broken regex fixed broken tasks problemMatcher regex Nov 11, 2022
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit b276ed0 into REditorSupport:master Nov 11, 2022
@gowerc gowerc deleted the regex-fix branch September 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants