Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace viewer command visibility #1323

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

ElianHugh
Copy link
Collaborator

  • save, clear, and refresh are disabled when there is no attached terminal
  • Load can be used at any time to attach a terminal + load data easily

image

  • View, remove, and quickpick are no longer shown in the command palette
    • these were not meant to be user-facing, and didn't do anything when called

image

- Save, Clear, and Refresh are disabled when there is no attached terminal
- Load can be used at any time to attach a terminal + load data easily
- View and Remove are no longer shown in the command palette
@ElianHugh ElianHugh changed the title Enablement changes, load anytime Workspace viewer command visibility Mar 6, 2023
@ElianHugh ElianHugh marked this pull request as ready for review March 6, 2023 03:46
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 28f00c7 into REditorSupport:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants