Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in getAliases.R #1334

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

csaybar
Copy link
Contributor

@csaybar csaybar commented Mar 21, 2023

What problem did you solve?

When an aliases.rds file in one of your installed packages is corrupt or improperly formatted, it can cause the documentation to fail every time it is requested, resulting in an error message that can be quite frustrating.

(x) Failed to get list of R functions. Make sure that jsonlite is installed and r.rpath.linux points to a valid R executable.
(x) Error in readRDS(filename) : error reading from connection Calls: lapply -> FUN -> as.list -> readRDS Execution halted

This PR adds a more informative message to the users.

@csaybar
Copy link
Contributor Author

csaybar commented Mar 21, 2023

I am not sure why I cannot upload images on GH, but I am able to upload PDF files.
bug01.pdf

@renkun-ken
Copy link
Member

Thanks for trying to fix the error handling. Unfortunately, the warning does not go to the user. I rewrite the code to make it work.

@renkun-ken renkun-ken changed the title Update getAliases.R Handle errors in getAliases.R Mar 24, 2023
@renkun-ken renkun-ken merged commit 17ac451 into REditorSupport:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants