Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to invoke R terminal also in relative paths #1398

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

Tal500
Copy link
Contributor

@Tal500 Tal500 commented Aug 5, 2023

Allow to invoke R terminal also in relative paths, and specify the right working directory for the workspace.

Now the user is allowed to enter a relative path in the option 'rterm', and this VSCode extension will invoke this relative path relative to the workspace directory. This is useful for example for people(like me) who have a bash script creating a remove R session.

@renkun-ken
Copy link
Member

Thanks for working on this!

Does it work properly in the following scenarios:

  • Single workspace but only no or untitled document is open/active.
  • Multi-root workspace
  • No open workspace folder

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit 942a4d4 into REditorSupport:master Oct 7, 2023
@Tal500
Copy link
Contributor Author

Tal500 commented Oct 7, 2023

Thanks for working on this!

Does it work properly in the following scenarios:

* Single workspace but only no or untitled document is open/active.

* Multi-root workspace

* No open workspace folder

I think it should work if I remember correctly, since it used the already implemented function getCurrentWorkspaceFolder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants