Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol 117 for BRESSER 7-in-1 Weather Center #1072

Merged
merged 7 commits into from
Feb 2, 2022

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No decoding of the transmission protocol of the sensor of the Bresser 7-in-1 weather station.
    https://forum.fhem.de/index.php/topic,78809.msg1196941.html#msg1196941

  • What is the new behavior (if this is a feature change)?
    Decoding of the transmission protocol of the sensor of the Bresser 7-in-1 weather station.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #1072 (1f9f93f) into master (4ee9399) will increase coverage by 0.52%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage   63.35%   63.87%   +0.52%     
==========================================
  Files         127      129       +2     
  Lines        9378     9461      +83     
  Branches     1480     1495      +15     
==========================================
+ Hits         5941     6043     +102     
+ Misses       2303     2269      -34     
- Partials     1134     1149      +15     
Flag Coverage Δ
fhem 55.59% <77.77%> (+0.67%) ⬆️
modules 63.87% <77.77%> (+0.52%) ⬆️
perl 90.70% <0.00%> (-1.06%) ⬇️
unittests 63.87% <77.77%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/lib/SD_Protocols.pm 79.69% <75.86%> (+0.10%) ⬆️
FHEM/14_SD_WS.pm 64.25% <79.16%> (+0.45%) ⬆️
FHEM/00_SIGNALduino.pm 64.65% <100.00%> (+1.18%) ⬆️
t/FHEM/14_SD_WS07/09_parseDatat.t 80.00% <0.00%> (ø)
t/FHEM/14_BresserTemeo/00_load.t 100.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 72.76% <0.00%> (+4.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee9399...1f9f93f. Read the comment docs.

FHEM/00_SIGNALduino.pm Outdated Show resolved Hide resolved
@sidey79 sidey79 added the SD_WS label Feb 1, 2022
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elektron-bbs

So jetzt passts mit der Vefersionsnummer :)

@elektron-bbs elektron-bbs merged commit cd1a840 into master Feb 2, 2022
@elektron-bbs elektron-bbs deleted the master_Bresser7in1 branch March 6, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants