Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol 118 for Meikee remote controls #1082

Merged
merged 10 commits into from
Mar 6, 2022
Merged

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No decoding of messages from Meikee remote controls
    https://forum.fhem.de/index.php/topic,126110.0.html

  • What is the new behavior (if this is a feature change)?
    Decoding of messages from Meikee remote controls with 21 and 24 buttons.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #1082 (987ad2e) into master (1595708) will increase coverage by 0.02%.
The diff coverage is 27.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   63.56%   63.58%   +0.02%     
==========================================
  Files         127      129       +2     
  Lines        9455     9480      +25     
  Branches     1497     1503       +6     
==========================================
+ Hits         6010     6028      +18     
- Misses       2293     2294       +1     
- Partials     1152     1158       +6     
Flag Coverage Δ
fhem 55.28% <27.77%> (-0.02%) ⬇️
modules 63.58% <27.77%> (+0.02%) ⬆️
perl 90.70% <ø> (+0.21%) ⬆️
unittests 63.58% <27.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_UT.pm 37.66% <23.52%> (-0.31%) ⬇️
FHEM/00_SIGNALduino.pm 63.46% <100.00%> (ø)
t/FHEM/14_BresserTemeo/00_load.t 100.00% <0.00%> (ø)
t/FHEM/14_FLAMINGO/00_load.t 100.00% <0.00%> (ø)
FHEM/lib/SD_Protocols.pm 79.69% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1595708...987ad2e. Read the comment docs.

@elektron-bbs elektron-bbs merged commit 87f2dd7 into master Mar 6, 2022
@HomeAutoUser HomeAutoUser deleted the master_SD_UT_Meikee branch March 8, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants